Ensures $xml_items is always an array before it's treated as such. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes PHP 7.1 warnings regarding “Illegal string offset” and “Cannot assign an empty string”.
|
Is there a reason that you released a version 9 days after this pull request with out the fix? |
|
Hi, not sure what you exactly mean, the latest version: 3.0.3 includes this fix: You can download it here: News: |
|
Great! I was just a bit confused because this pull request hasn't been merged and the code in the main branch doesn't appear to have the changes. The main branch appears to be from two years ago (v3.00). Cheers and I think PhocaCommander is an awesome extension ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PHP 7.1 warnings regarding “Illegal string offset” and “Cannot assign an empty string”.